Create an account

Very important

  • To access the important data of the forums, you must be active in each forum and especially in the leaks and database leaks section, send data and after sending the data and activity, data and important content will be opened and visible for you.
  • You will only see chat messages from people who are at or below your level.
  • More than 500,000 database leaks and millions of account leaks are waiting for you, so access and view with more activity.
  • Many important data are inactive and inaccessible for you, so open them with activity. (This will be done automatically)


Thread Rating:
  • 456 Vote(s) - 3.53 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Execute .bat file from Excel VBA Macro

#1
Im having a problem with my excel vba macro. I need it to execute a batch file which is in the same folder as the excel workbook. The code works well sometimes. I don't know whats causing the error. Here's the code:

Sub writebatch()
Sheets("code").Select
Application.DisplayAlerts = False
ActiveWorkbook.SaveAs FileName:=ThisWorkbook.path & "\code.bat",
FileFormat:=xlTextPrinter, CreateBackup:=False
Application.DisplayAlerts = True
ThisWorkbook.Saved = True
Shell "cmd.exe /k cd " & ThisWorkbook.path & "&&code.bat"
Application.Quit
End Sub

It writes the batch file, but then doesn't execute it. Only once I got the command window to not close and it said the code.bat file could not be found. So the changedir command worked. Is it possible to run cmd.exe and run the code.bat with the relative path without having to changedir?
Reply

#2
I'm pretty sure the problem is down to this line

Shell "cmd.exe /k cd " & ThisWorkbook.path & "&&code.bat"

You need a space in front of the `&&` to separate it from the `cd` command and after it to separate it from the `code.bat`.

Shell "cmd.exe /k cd " & ThisWorkbook.path & " && code.bat"
Reply

#3
First of all, when you launch a CMD instance you need to enclose the entire CMD argument if you use any type of operators (&):

CMD /K "command1 & command2"

And then enclose the sub-internal arguments, like this:

CMD /K "command "path with spaces" & command"


So you need to do something like this:

Shell "cmd.exe /k ""cd " & """ & ThisWorkbook.path & """ & " && code.bat"""


Notice I've used """ to escape a quote, but I don't know the way to escape a quote in VBA.

PS: remember to also enclose the **code.bat** if you have spaces, but ONLY if you have spaces.
Reply

#4
Shell "cmd.exe /k cd /d" & ThisWorkbook.path & "&& code.bat"

here, without /d cmd will open in document folder.
by /d it will open in d drive, you may change this as per your easy.
Reply

#5
One way to insert a quote(") into a string is by using the character code conversion function Chr(34), 34 being the ASCII value for quotes(")
Reply

#6
I hope it will useful for you.
```
Dim sfilename, fileName As String
Sub Run_file_bat()
fileName = "" & ThisWorkbook.Path & "\code.bat" & ""

VBA.Shell "Explorer.exe " & fileName, vbNormalFocus

End Sub
```
Reply



Forum Jump:


Users browsing this thread:
1 Guest(s)

©0Day  2016 - 2023 | All Rights Reserved.  Made with    for the community. Connected through