Create an account

Very important

  • To access the important data of the forums, you must be active in each forum and especially in the leaks and database leaks section, send data and after sending the data and activity, data and important content will be opened and visible for you.
  • You will only see chat messages from people who are at or below your level.
  • More than 500,000 database leaks and millions of account leaks are waiting for you, so access and view with more activity.
  • Many important data are inactive and inaccessible for you, so open them with activity. (This will be done automatically)


Thread Rating:
  • 1138 Vote(s) - 3.51 Average
  • 1
  • 2
  • 3
  • 4
  • 5
"Use of uninitialised value" despite of memset

#1
I allocate a 2d array and use memset to fill it with zeros.

#include<stdio.h>
#include<string.h>
#include<stdlib.h>

void main() {
int m=10;
int n =10;
int **array_2d;
array_2d = (int**) malloc(m*sizeof(int*));
if(array_2d==NULL) {
printf("\n Could not malloc 2d array \n");
exit(1);
}
for(int i=0;i<m;i++) {
((array_2d)[i])=malloc(n*sizeof(int));
memset(((array_2d)[i]),0,sizeof(n*sizeof(int)));
}


for(int i=0; i<10;i++){
for(int j=0; j<10;j++){
printf("(%i,%i)=",i,j);
fflush(stdout);
printf("%i ", array_2d[i][j]);
}
printf("\n");
}
}

Afterwards I use valgrind [1] to check for memory errors. I get following error: `Conditional jump or move depends on uninitialised value(s)` for line 24 (`printf("%i ", array_2d[i][j]);`). I always thought memset is the function to initialize arrays. How can I get rid off this error?

Thanks!

Valgrind output:

==3485== Memcheck, a memory error detector
==3485== Copyright © 2002-2009, and GNU GPL'd, by Julian Seward et al.
==3485== Using Valgrind-3.5.0-Debian and LibVEX; rerun with -h for copyright info
==3485== Command: ./a.out
==3485==
(0,0)=0 (0,1)===3485== Use of uninitialised value of size 4
==3485== at 0x409E186: _itoa_word (_itoa.c:195)
==3485== by 0x40A1AD1: vfprintf (vfprintf.c:1613)
==3485== by 0x40A8FFF: printf (printf.c:35)
==3485== by 0x8048724: main (playing_with_valgrind.c:39)
==3485==
==3485==
==3485== ---- Attach to debugger ? --- [Return/N/n/Y/y/C/c] ----
==3485== Conditional jump or move depends on uninitialised value(s)
==3485== at 0x409E18E: _itoa_word (_itoa.c:195)
==3485== by 0x40A1AD1: vfprintf (vfprintf.c:1613)
==3485== by 0x40A8FFF: printf (printf.c:35)
==3485== by 0x8048724: main (playing_with_valgrind.c:39)



[1] `valgrind --tool=memcheck --leak-check=yes --show-reachable=yes --num-callers=20 --track-fds=yes --db-attach=yes ./a.out`

[gcc-cmd] `gcc -std=c99 -lm -Wall -g3 playing_with_valgrind.c`






Reply

#2
At this line:

/* sizeof(n*sizeof(int)) retuns a value of type size_t.
This means you are initializing only sizeof(size_t) of the array. */
memset(((array_2d)[i]),0,sizeof(n*sizeof(int)));
It should be:

memset(((array_2d)[i]),0, n*sizeof(int));



Reply

#3
Change the statement:

memset(((array_2d)[i]),0,sizeof(n*sizeof(int)));

to:

memset(((array_2d)[i]),0,n*sizeof(int));

You should not be doing a `sizeof` there. It will just return the size of the type of the variable, which is not what you want.
Reply



Forum Jump:


Users browsing this thread:
1 Guest(s)

©0Day  2016 - 2023 | All Rights Reserved.  Made with    for the community. Connected through